Use Service Account JSON Key File #11335
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is recommended by Google that we use Service Account credentials make API calls from server. See [this issue comment](pandas-dev#8489 (comment)) for details. Signed-off-by: John Wu <[email protected]>
| @@ -109,9 +110,10 @@ class TableCreationError(PandasError, ValueError): | |||
|
|
|||
| class GbqConnector(object): | |||
|
|
|||
| def __init__(self, project_id, reauth=False): | |||
| def __init__(self, project_id, key_file, reauth=False): | |||
There was a problem hiding this comment.
should be key which could be a file (or not) and should be optional
|
closing, but if you'd like to update, pls reopen |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is recommended by Google that we use Service Account credentials make
API calls from server. See this issue comment for details.
Docs and tests are not yet updated. DO NOT MERGE.